Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for android 13+ themed icons #497

Merged
merged 2 commits into from
Dec 29, 2023
Merged

feat: added support for android 13+ themed icons #497

merged 2 commits into from
Dec 29, 2023

Conversation

OutdatedGuy
Copy link
Contributor

@OutdatedGuy OutdatedGuy commented Jun 20, 2023 •
edited
Loading

New

Changes

  • Changed logic of how mipmap xml file is created to be more readable and concise.

closes #458; closes #419;

@ua741 ua741 mentioned this pull request Oct 18, 2023
Closed
@josh-burton
Copy link

josh-burton commented Dec 4, 2023 •
edited
Loading

Is there anything preventing this PR from being merged? Can the tests be run again?

@MarkOSullivan94 @RatakondalaArun

@OutdatedGuy OutdatedGuy reopened this Dec 11, 2023
@OutdatedGuy
Copy link
Contributor Author

Hi @MarkOSullivan94, can you review this PR and tell me if changes are needed.

MarkOSullivan94
MarkOSullivan94 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@MarkOSullivan94 MarkOSullivan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! 🥳

@MarkOSullivan94 MarkOSullivan94 merged commit 006cb1e into fluttercommunity:master Dec 29, 2023
1 check passed
@MarkOSullivan94
Copy link
Collaborator

@OutdatedGuy this is a major new feature for flutter_launcher_icons and with it I'm happy to see us make a new release for it so people can try out

@OutdatedGuy OutdatedGuy deleted the feat/monochrome-icons-support branch December 29, 2023 18:08
@jennie-metacast
Copy link

Very excited about this feature - any idea of the time frame for releasing it? Thanks!

@josh-burton
Copy link

Very excited about this feature - any idea of the time frame for releasing it? Thanks!

In the meantime, you can use the latest master version:

  flutter_launcher_icons:
    git: [email protected]:fluttercommunity/flutter_launcher_icons.git

@rileychh rileychh mentioned this pull request Feb 13, 2024
Draft
@And96
Copy link

And96 commented Mar 20, 2024

Merged but not availabe via pub.dev ?

@And96
Copy link

And96 commented Mar 20, 2024

Very excited about this feature - any idea of the time frame for releasing it? Thanks!

In the meantime, you can use the latest master version:

  flutter_launcher_icons:
    git: [email protected]:fluttercommunity/flutter_launcher_icons.git

Didnt work for me.
In pubspec.yaml I have to use:

flutter_launcher_icons: git: url: https://github.com/fluttercommunity/flutter_launcher_icons ref: master

@coyotte508 coyotte508 mentioned this pull request Apr 20, 2024
Closed
@piu130 piu130 mentioned this pull request Sep 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkOSullivan94 MarkOSullivan94 MarkOSullivan94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Android 13 themed icons [FEATURE REQUEST] Support for android 13 themed icons
5 participants
@OutdatedGuy @josh-burton @MarkOSullivan94 @jennie-metacast @And96